Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I/7560: Update Image feature docs and change the image alignment styles behaviour. #7625

Merged
merged 10 commits into from
Jul 21, 2020
Merged

I/7560: Update Image feature docs and change the image alignment styles behaviour. #7625

merged 10 commits into from
Jul 21, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Jul 15, 2020 •
edited
Loading

Suggested merge commit message (convention)

Docs (image): Updated Image feature documentation for the ImageStyle and ImageResize plugins. Closes #7560.

Docs (image): Divided the ImageStyle documentation into semantical and presentational styles with corresponding snippets configuration.

BREAKING CHANGE (image): Image alignment styles (alignLeft, alignCenter and alignRight) will no longer set max-width: 50%; to the <figure> element with the related CSS classes.

Tests (image): Updated manual tests configurations for the ImageResize feature.

@Reinmar
Copy link
Member

Reinmar commented Jul 21, 2020

I get this after opening the docs:

@Reinmar Reinmar merged commit a4cbcf1 into master Jul 21, 2020
@Reinmar Reinmar deleted the i/7560 branch July 21, 2020 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reinmar Reinmar Reinmar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Conceptual problems between image styles and image resize
2 participants
@panr @Reinmar